Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload coverage reports to codecov #1132

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

paulelliott
Copy link
Member

@paulelliott paulelliott commented Dec 17, 2024

This PR replaces Codacy with Codecov. You can test by going to the branch for this one in Codecov and seeing the coverage. Looks like vitest emits coverage for all files, not just executed ones, so we have a complete report by default.

Closes CAP-2546

📦 Published PR as canary version: 11.20.3--canary.1132.12396133002.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@paulelliott paulelliott self-assigned this Dec 17, 2024
Copy link
Contributor

github-actions bot commented Dec 17, 2024

📦 Package Size: 5448 KB

@paulelliott paulelliott added the internal Classification: Changes only affect the internal API label Dec 17, 2024
Copy link

codacy-production bot commented Dec 17, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 10eb7531 (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (10eb753) Report Missing Report Missing Report Missing
Head commit (463c94a) 7304 5031 68.88%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1132) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@paulelliott paulelliott reopened this Dec 17, 2024
@paulelliott paulelliott force-pushed the paulelliott/set-up-codecov branch from 5044a2d to 463c94a Compare December 17, 2024 22:37
Copy link

codecov bot commented Dec 17, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@paulelliott paulelliott marked this pull request as ready for review December 18, 2024 13:47
@paulelliott paulelliott requested a review from codykaup December 18, 2024 13:47
@paulelliott
Copy link
Member Author

@codykaup Can you fix the labels on this one?

@paulelliott paulelliott marked this pull request as draft December 18, 2024 13:50
@paulelliott paulelliott added the skip-release Auto: Preserve the current version when merged label Dec 18, 2024
We need this in order to track code coverage properly
@paulelliott paulelliott marked this pull request as ready for review December 18, 2024 13:58
@codykaup codykaup added the minor Auto: Increment the minor version when merged label Dec 18, 2024
Copy link
Contributor

@codykaup codykaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@paulelliott paulelliott added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 9dbaef7 Dec 18, 2024
23 of 24 checks passed
@paulelliott paulelliott deleted the paulelliott/set-up-codecov branch December 18, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Classification: Changes only affect the internal API minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants