-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support for JSON5 as a configuration file. #1118
Conversation
This adds support for JSON5 as a configuration file language, allowing for an extension to JSON that supports comments and other features. Fixes CAP-2357. Fixes #1114.
📦 Package Size: 5408 KB |
66075c8
to
c4086bf
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense to me. This feels more like a minor
rather than a patch
to me since it's not a bug. Also, don't forget to add release
/skip-release
!
Ok, I'll switch to |
Yep, I would release this one. I only use |
2ff92c0
to
36eeaab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some more things I noticed now that this supports .json5
!
cd6e838
to
d36d95e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, nice work!
d36d95e
to
aa5e4fc
Compare
🚀 PR was released in |
This adds support for JSON5 as a configuration file language, allowing for an extension to JSON that supports comments and other features.
Fixes CAP-2357.
Fixes #1114.
📦 Published PR as canary version:
11.18.0--canary.1118.11728711367.0
✨ Test out this PR locally via: