Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nicer formatting to TS bail reasons. #1095

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Oct 11, 2024

Previously we were printing [object Object] there, something must have shifted in the types.

This adds nice formatting for this object;

Screenshot 2024-10-11 at 10 43 49 AM
📦 Published PR as canary version: 11.12.7--canary.1095.11388112139.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@jmhobbs jmhobbs added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Oct 11, 2024
@jmhobbs jmhobbs requested a review from a team October 11, 2024 15:44
@jmhobbs jmhobbs self-assigned this Oct 11, 2024
Copy link

codacy-production bot commented Oct 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.29% (target: -1.00%) 2.08% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3953912) 8460 4652 54.99%
Head commit (be770f7) 8507 (+47) 4653 (+1) 54.70% (-0.29%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1095) 48 1 2.08%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

github-actions bot commented Oct 11, 2024

📦 Package Size: 5268 KB
✅ Compared to main: 0 KB 6890d08 (5268 KB)

Copy link
Contributor

@jwir3 jwir3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, With some super minor nitpicks. You can choose to make the changes or not.

node-src/types.ts Show resolved Hide resolved
node-src/types.ts Show resolved Hide resolved
node-src/ui/messages/info/tracedAffectedFiles.ts Outdated Show resolved Hide resolved
@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2283-turbosnap-behavior-changed-after-implementing-rspack branch from 9704a25 to 92c79bb Compare October 17, 2024 14:51
@jmhobbs jmhobbs added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 5899099 Oct 17, 2024
20 of 21 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-2283-turbosnap-behavior-changed-after-implementing-rspack branch October 17, 2024 15:24
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.12.6 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants