Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use --stats-json flag for SB 8.0.0+" #1046

Conversation

maxcorbin
Copy link
Contributor

@maxcorbin maxcorbin commented Sep 13, 2024

Reverts #1035

📦 Published PR as canary version: 11.10.3--canary.1046.10848066932.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

Copy link

linear bot commented Sep 13, 2024

@maxcorbin maxcorbin requested a review from tmeasday September 13, 2024 11:04
@tmeasday tmeasday added the patch Auto: Increment the patch version when merged label Sep 13, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (68338db) 8322 4492 53.98%
Head commit (ba8c70f) 8317 (-5) 4487 (-5) 53.95% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1046) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@tmeasday tmeasday added the release Auto: Create a `latest` release when merged label Sep 13, 2024
@tmeasday tmeasday added this pull request to the merge queue Sep 13, 2024
@tmeasday tmeasday removed this pull request from the merge queue due to a manual request Sep 13, 2024
@tmeasday tmeasday added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 6ec5b60 Sep 13, 2024
22 of 24 checks passed
@tmeasday tmeasday deleted the revert-1035-jmhobbs/cap-2186-gha-doesnt-recognize-the-flag-stats-json branch September 13, 2024 11:10
@ghengeveld
Copy link
Member

🚀 PR was released in v11.10.2 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants