Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky missing dependency test #1043

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Sep 12, 2024

It appears we send a series of promises to search for various view layers and use the first one to resolve. The problem with this test is we're using our own node_modules directory and we import two view layers from that list. Since the resolution of those promises is non-deterministic, this test can fail randomly.

To fix that problem, we can simply look for either option!

📦 Published PR as canary version: 11.10.3--canary.1043.10848066576.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@codykaup codykaup added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Sep 12, 2024
@codykaup codykaup self-assigned this Sep 12, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b5e1dd31 (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b5e1dd3) Report Missing Report Missing Report Missing
Head commit (11e24ee) 8322 4492 53.98%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1043) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@codykaup codykaup requested a review from a team September 12, 2024 20:50
Copy link
Contributor

@jmhobbs jmhobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! 👏

@codykaup codykaup added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@codykaup codykaup added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 0c9674a Sep 12, 2024
23 of 24 checks passed
@codykaup codykaup deleted the cody/cap-2183-node-srclibgetstorybookinfotestts-getstorybookinfo-looks-up branch September 12, 2024 21:05
@ghengeveld
Copy link
Member

🚀 PR was released in v11.10.2 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants