Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic unicorn setup to ESLint config #1041

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Sep 11, 2024

This adds a very basic configuration for unicorn. I filtered a bunch of rules to prevent this PR from getting too big. The idea is to enable those rules over time one-by-one.

📦 Published PR as canary version: 11.10.2--canary.1041.10837457365.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@codykaup codykaup added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Sep 11, 2024
@codykaup codykaup self-assigned this Sep 11, 2024
Copy link

codacy-production bot commented Sep 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 62.02% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4a04431) 8312 4484 53.95%
Head commit (0b68b73) 8317 (+5) 4487 (+3) 53.95% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1041) 258 160 62.02%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codykaup codykaup requested a review from a team September 11, 2024 21:37
node-src/git/git.ts Outdated Show resolved Hide resolved
node-src/lib/logSerializers.test.ts Outdated Show resolved Hide resolved
@codykaup codykaup force-pushed the cody/cap-2199-eslint-add-unicorn-config branch 2 times, most recently from 15df693 to 7e18667 Compare September 12, 2024 17:20
@codykaup codykaup force-pushed the cody/cap-2199-eslint-add-unicorn-config branch from 7e18667 to 0b68b73 Compare September 12, 2024 17:20
@codykaup codykaup added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@codykaup codykaup added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit da3ab1e Sep 12, 2024
18 of 19 checks passed
@codykaup codykaup deleted the cody/cap-2199-eslint-add-unicorn-config branch September 12, 2024 17:30
@ghengeveld
Copy link
Member

🚀 PR was released in v11.10.1 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants