Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial TypeScript errors #1033

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Sep 10, 2024

This fixes the handful of TypeScript errors we currently have. The largest change is upgrading vitest to 2.0.5 to use vi.mock(import('./lib/e2e')) for pulling types out of ./lib/e2e.

📦 Published PR as canary version: 11.9.1--canary.1033.10818999162.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@codykaup codykaup added minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged labels Sep 10, 2024
Copy link

codacy-production bot commented Sep 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 93e88431 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (93e8843) Report Missing Report Missing Report Missing
Head commit (c8cf4f3) 8287 4474 53.99%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1033) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@codykaup codykaup self-assigned this Sep 10, 2024
@codykaup codykaup requested review from ghengeveld, tevanoff and a team September 10, 2024 15:11
Copy link
Contributor

@jmhobbs jmhobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one question.

node-src/lib/checkForUpdates.ts Show resolved Hide resolved
@codykaup codykaup force-pushed the cody/cap-2175-fix-initial-typescript-errors branch from b981a9b to c8cf4f3 Compare September 11, 2024 14:57
@codykaup codykaup added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 253c46c Sep 11, 2024
20 checks passed
@codykaup codykaup deleted the cody/cap-2175-fix-initial-typescript-errors branch September 11, 2024 15:32
@ghengeveld
Copy link
Member

🚀 PR was released in v11.9.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants