-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initial TypeScript errors #1033
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just one question.
b981a9b
to
c8cf4f3
Compare
🚀 PR was released in |
This fixes the handful of TypeScript errors we currently have. The largest change is upgrading
vitest
to2.0.5
to usevi.mock(import('./lib/e2e'))
for pulling types out of./lib/e2e
.📦 Published PR as canary version:
11.9.1--canary.1033.10818999162.0
✨ Test out this PR locally via: