Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't upload files from .chromatic directory #1028

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Aug 28, 2024

This is largely caused by using pre-built storybooks with the -d / --storybook-build-dir flag. Filtering out this directory will prevent accidental upload of reserved files like trace metadata or processing sentinels.

📦 Published PR as canary version: 11.9.0--canary.1028.10799660620.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

This is largely caused by using pre-built storybooks with the -d /
--storybook-build-dir flag.  It will prevent accidental upload of
reserved files like trace metadata or processing sentinels.
@jmhobbs jmhobbs requested a review from a team August 28, 2024 22:20
@jmhobbs jmhobbs self-assigned this Aug 28, 2024
Copy link

codacy-production bot commented Aug 28, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 5f0500f1 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5f0500f) Report Missing Report Missing Report Missing
Head commit (69e24e0) 8478 6698 79.00%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1028) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jmhobbs jmhobbs added enhancement Classification: New feature or request minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged labels Aug 29, 2024
Copy link
Contributor

@codykaup codykaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

node-src/tasks/upload.ts Outdated Show resolved Hide resolved
@ghengeveld
Copy link
Member

This is good. I was worried we wouldn't be uploading any metadata files anymore, but that's actually handled in a separate file (uploadMetadataFiles.ts).

@ghengeveld ghengeveld changed the title Do not collect files inside .chromatic for upload. Don't upload files from .chromatic directory Sep 5, 2024
@jmhobbs jmhobbs added this pull request to the merge queue Sep 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2024
@jmhobbs jmhobbs added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 049eebf Sep 10, 2024
20 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-1581-refuse-to-upload-chromatic branch September 10, 2024 19:55
@ghengeveld
Copy link
Member

🚀 PR was released in v11.8.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Classification: New feature or request minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants