-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't upload files from .chromatic
directory
#1028
Conversation
This is largely caused by using pre-built storybooks with the -d / --storybook-build-dir flag. It will prevent accidental upload of reserved files like trace metadata or processing sentinels.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is good. I was worried we wouldn't be uploading any metadata files anymore, but that's actually handled in a separate file ( |
.chromatic
directory
🚀 PR was released in |
This is largely caused by using pre-built storybooks with the
-d
/--storybook-build-dir
flag. Filtering out this directory will prevent accidental upload of reserved files like trace metadata or processing sentinels.📦 Published PR as canary version:
11.9.0--canary.1028.10799660620.0
✨ Test out this PR locally via: