Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key to configuration to fix #1022 #1023

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Add key to configuration to fix #1022 #1023

merged 1 commit into from
Aug 14, 2024

Conversation

winkerVSbecks
Copy link
Member

@winkerVSbecks winkerVSbecks commented Aug 14, 2024

We now offer the option to validate the config file using JSON schema. This PR allows the user to specify the schema within the config file itself.

Fixes #1022

📦 Published PR as canary version: 11.7.2--canary.1023.10395197551.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 9edbdc01 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9edbdc0) Report Missing Report Missing Report Missing
Head commit (c215322) 8473 6692 78.98%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1023) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@winkerVSbecks winkerVSbecks added the patch Auto: Increment the patch version when merged label Aug 14, 2024
@winkerVSbecks winkerVSbecks added the release Auto: Create a `latest` release when merged label Aug 14, 2024
@winkerVSbecks
Copy link
Member Author

@thafryer I don't have merge access. Could you merge this in when you get a chance. Thank you

@skitterm skitterm added this pull request to the merge queue Aug 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2024
@skitterm skitterm added this pull request to the merge queue Aug 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2024
@skitterm skitterm added this pull request to the merge queue Aug 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2024
@skitterm
Copy link
Member

@winkerVSbecks I'm seeing a test failing that is preventing the merge queue from merging this PR. Are the tests passing for you locally? This test has failed before, but rerunning the CI build a couple times didn't resolve it for me.

@winkerVSbecks
Copy link
Member Author

@skitterm trace.test.ts is failing for me locally. But not this one. I'm not sure why either are failing. This is my first contribution to this codebase.

@winkerVSbecks winkerVSbecks changed the title add key to configuration to fix #1022 Add key to configuration to fix #1022 Aug 14, 2024
@winkerVSbecks
Copy link
Member Author

@skitterm actually all tests pass locally now. I just hadn't run a build so trace tests were failing.

@skitterm skitterm added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit e82db1d Aug 14, 2024
25 of 27 checks passed
@skitterm skitterm deleted the fix-schema-validation branch August 14, 2024 21:20
@ghengeveld
Copy link
Member

🚀 PR was released in v11.7.1 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrecognized key(s) in object: '$schema'
4 participants