-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logic to account for parentheses at the beginning #1016
Added logic to account for parentheses at the beginning #1016
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Closing this because it's an issue on the Chromatic monorepo side. |
Actually, we need this one for when brackets are at the beginning and end of a pattern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[👍🏻]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🚀 PR was released in |
The original pattern to address the split of the special characters didn't account for the empty string at the beginning and end of the pattern. We only want to ignore empty strings in the middle of the string.
📦 Published PR as canary version:
11.7.0--canary.1016.10180148485.0
✨ Test out this PR locally via: