Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic to account for parentheses at the beginning #1016

Conversation

ethriel3695
Copy link
Contributor

@ethriel3695 ethriel3695 commented Jul 22, 2024

The original pattern to address the split of the special characters didn't account for the empty string at the beginning and end of the pattern. We only want to ignore empty strings in the middle of the string.

📦 Published PR as canary version: 11.7.0--canary.1016.10180148485.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

Copy link

codacy-production bot commented Jul 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for c91d3011 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c91d301) Report Missing Report Missing Report Missing
Head commit (8079d57) 8463 6682 78.96%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1016) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@ethriel3695 ethriel3695 added bug Classification: Something isn't working release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Jul 22, 2024
@ethriel3695
Copy link
Contributor Author

Closing this because it's an issue on the Chromatic monorepo side.

@ethriel3695
Copy link
Contributor Author

Actually, we need this one for when brackets are at the beginning and end of a pattern.

@ethriel3695 ethriel3695 reopened this Jul 23, 2024
Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[👍🏻]

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ethriel3695 ethriel3695 added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 295aaf5 Jul 31, 2024
20 checks passed
@ethriel3695 ethriel3695 deleted the reuben/ap-4736-ts-when-file-names-have-special-characters-eg-ts-is-unable branch July 31, 2024 12:24
@ghengeveld
Copy link
Member

🚀 PR was released in v11.6.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants