Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-local ancestor builds with uncommittedHash #1015

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Support non-local ancestor builds with uncommittedHash #1015

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5758a00
Only check for the hash if the build is local
skitterm Jul 19, 2024
1719c78
Add test for changes
tmeasday Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion node-src/git/findAncestorBuildWithCommit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ export async function findAncestorBuildWithCommit(
return [build, exists] as const;
})
);
const result = results.find(([build, exists]) => !build.uncommittedHash && exists);
const result = results.find(
([build, exists]) => !(build.isLocalBuild && build.uncommittedHash) && exists
);

if (result) return result[0];

Expand Down
Loading