Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-local ancestor builds with uncommittedHash #1015

Merged
merged 2 commits into from
Jul 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions node-src/git/findAncestorBuildWithCommit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const makeBuild = (build: Partial<Build> = {}): Build => ({
number: 1,
commit: 'missing',
uncommittedHash: '',
isLocalBuild: false,
...build,
});
const makeResult = (ancestorBuilds: Build[]): AncestorBuildsQueryResult => ({
Expand All @@ -36,14 +37,24 @@ describe('findAncestorBuildWithCommit', () => {
expect(client.runQuery.mock.calls[0][1]).toMatchObject({ buildNumber: 1 });
});

it('does not return build with uncommitted changes', async () => {
it('does not return a local build with uncommitted changes', async () => {
client.runQuery.mockReturnValue(
makeResult([makeBuild({ commit: 'exists', uncommittedHash: 'abc123' })])
makeResult([makeBuild({ commit: 'exists', uncommittedHash: 'abc123', isLocalBuild: true })])
);

expect(await findAncestorBuildWithCommit({ client }, 1, { page: 1, limit: 1 })).toBeNull();
});

it('DOES return a CI build with uncommitted changes', async () => {
client.runQuery.mockReturnValue(
makeResult([makeBuild({ commit: 'exists', uncommittedHash: 'abc123' })])
);

expect(await findAncestorBuildWithCommit({ client }, 1, { page: 1, limit: 1 })).toMatchObject({
commit: 'exists',
});
});

it('passes skip and limit and recurse', async () => {
const toFind = makeBuild({ number: 3, commit: 'exists' });
client.runQuery
Expand Down
4 changes: 3 additions & 1 deletion node-src/git/findAncestorBuildWithCommit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ export async function findAncestorBuildWithCommit(
return [build, exists] as const;
})
);
const result = results.find(([build, exists]) => !build.uncommittedHash && exists);
const result = results.find(
([build, exists]) => !(build.isLocalBuild && build.uncommittedHash) && exists
);

if (result) return result[0];

Expand Down
Loading