Skip to content

Commit

Permalink
Use Node LTS in CI workflows and drop Node 14/16 smoke tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ghengeveld committed Oct 18, 2023
1 parent 58a5b74 commit 862b3fb
Show file tree
Hide file tree
Showing 14 changed files with 12 additions and 61 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2
jobs:
build:
docker:
- image: cimg/node:16.18.0
- image: cimg/node:lts
resource_class: xlarge

working_directory: ~/repo
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/chromatic-main-and-prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: lts/*
- name: install
run: yarn install --frozen-lockfile
- uses: chromaui/action@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/chromatic-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: lts/*
- name: install
run: yarn install --frozen-lockfile
- uses: chromaui/action-next@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/chromatic-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: lts/*
- name: install
run: yarn install --frozen-lockfile
- uses: chromaui/action-canary@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/smoke-test-action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: lts/*
- run: yarn
- run: yarn build
- uses: ./
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/smoke-test-node-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: lts/*
- run: yarn
- name: run chromatic via node
run: yarn ts-node ./scripts/run-via-node.ts
Expand Down
24 changes: 0 additions & 24 deletions .github/workflows/smoke-test-node14.yml

This file was deleted.

25 changes: 0 additions & 25 deletions .github/workflows/smoke-test-node16.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/smoke-test-npx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: lts/*
- name: install
run: yarn && git status --porcelain
- name: prep package
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/smoke-test-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: lts/*
- name: install
run: yarn
- name: prep package
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/smoke-test-yarn-berry.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: lts/*
- run: rm -rf subdir # remove conflicting subproject
- run: yarn set version berry
- name: install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/smoke-test-yarn-canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 18
node-version: lts/*
- run: rm -rf subdir # remove conflicting subproject
- run: yarn set version canary
- name: install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/smoke-test-yarn-classic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: lts/*
- run: rm -rf subdir # remove conflicting subproject
- run: yarn set version 1.x.x
- run: yarn install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/smoke-test-yarn.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: lts/*
- run: yarn
- run: yarn build
- run: yarn chromatic --build-script-name build-test-storybook --exit-zero-on-changes --force-rebuild
Expand Down

0 comments on commit 862b3fb

Please sign in to comment.