Pass AbortSignal to Execa

chromaui · Sep 22, 2023 · 7f1b68b · 7f1b68b
1 parent b107a8c
commit 7f1b68b
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/node-src/tasks/build.ts b/node-src/tasks/build.ts
@@ -69,22 +69,15 @@ export const buildStorybook = async (ctx: Context) => {
     logFile.on('error', reject);
   });
 
-  const { experimental_abortSignal: abortSignal } = ctx.options;
-
+  const { experimental_abortSignal: signal } = ctx.options;
   try {
     const { command } = ctx.spawnParams;
     ctx.log.debug('Using spawnParams:', JSON.stringify(ctx.spawnParams, null, 2));
 
-    let subprocess = null;
-    if (abortSignal) {
-      abortSignal.onabort = () => {
-        subprocess?.kill('SIGTERM', { forceKillAfterTimeout: 2000 });
-      };
-    }
-    subprocess = execaCommand(command, { stdio: [null, logFile, logFile] });
+    const subprocess = execaCommand(command, { stdio: [null, logFile, logFile], signal });
     await Promise.race([subprocess, timeoutAfter(ctx.env.STORYBOOK_BUILD_TIMEOUT)]);
   } catch (e) {
-    abortSignal?.throwIfAborted();
+    signal?.throwIfAborted();
 
     const buildLog = readFileSync(ctx.buildLogFile, 'utf8');
     ctx.log.error(buildFailed(ctx, e, buildLog));