Fix RT #73556 T::MO::Extends->mock should preserve prototype #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RT #73556: Test::MockObject::Extends->mock should duplicate prototype This test case shows the problem: a 'Prototype mismatch' warning is raised when a method declared with a prototype is replaced with a mock. The problem comes from the mock() implementation that wraps the mock in a sub without prototype. The same kind of problem occurs for subs with attributes (lvalue for example). This work has been sponsored by Ijenko.
Still TODO: preserve lvalue attribute
| @@ -0,0 +1,48 @@ | |||
| use 5.010; | |||
There was a problem hiding this comment.
Why you force to use 5.10 here? AFAIK there no such requirements for the module?
There was a problem hiding this comment.
Thanks for the catch!
|
@chromatic Could you review this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case & fix for RT#73556.
Attributes (such as lvalue) are still to do, but I have yet no idea of how to do it.