Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Round robin grpc connections amongst N query nodes #3454

Merged
merged 6 commits into from
Jan 15, 2025
Merged

[ENH] Round robin grpc connections amongst N query nodes #3454

merged 6 commits into from
Jan 15, 2025

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jan 9, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Retries requests in a round robin fashion (preserving existing tracing and configuration of the retry interceptor)
    • Retries requests across query_replication_factor nodes in round robin fashion.
  • New functionality
    • None
Screenshot 2025-01-14 at 3 18 01 PM

Test plan

How are these changes tested?
Testing retries, oh my. Wouldn't that be nice?
We could, but it requires more investment than its worth. I manually verified it for now, and cut a task.

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

This was referenced Jan 9, 2025
Merged
Merged
@HammadB Graphite App
Copy link
Collaborator Author

HammadB commented Jan 9, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@HammadB HammadB changed the title round robin [ENH] Round robin grpc connections amongst N query nodes Jan 9, 2025
@HammadB HammadB force-pushed the hammad/use_name_for_routing branch from 4b047d7 to 177103a Compare January 9, 2025 20:42
@HammadB HammadB force-pushed the hammad/round_robin_n branch from 38eba2a to 8d47f5d Compare January 9, 2025 20:42
@HammadB HammadB force-pushed the hammad/use_name_for_routing branch from 177103a to f6a5af6 Compare January 14, 2025 00:44
@HammadB HammadB force-pushed the hammad/round_robin_n branch from 8d47f5d to b0366ea Compare January 14, 2025 00:54
@HammadB HammadB marked this pull request as ready for review January 14, 2025 23:19
@codetheweb codetheweb self-requested a review January 14, 2025 23:25
@HammadB HammadB requested a review from Sicheng-Pan January 14, 2025 23:58
Sicheng-Pan
Sicheng-Pan approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@HammadB HammadB force-pushed the hammad/use_name_for_routing branch from 30d3e2b to 7ffc4f4 Compare January 15, 2025 01:32
@HammadB HammadB force-pushed the hammad/round_robin_n branch from 1041358 to 7fadd8c Compare January 15, 2025 01:32
@HammadB HammadB force-pushed the hammad/use_name_for_routing branch from 7ffc4f4 to 123c15a Compare January 15, 2025 01:41
@HammadB HammadB force-pushed the hammad/round_robin_n branch from 7fadd8c to f6373de Compare January 15, 2025 01:41
@HammadB HammadB force-pushed the hammad/round_robin_n branch from f6373de to 44560fd Compare January 15, 2025 01:45
@HammadB HammadB changed the base branch from hammad/use_name_for_routing to main January 15, 2025 01:45
@HammadB HammadB enabled auto-merge (squash) January 15, 2025 02:21
@HammadB HammadB merged commit 4442978 into main Jan 15, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sicheng-Pan Sicheng-Pan Sicheng-Pan approved these changes

@codetheweb codetheweb codetheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HammadB @codetheweb @Sicheng-Pan