[ENH] Validate HNSW index integrity on load #3369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
reviewed
Dec 30, 2024
| @@ -94,6 +94,7 @@ class Index | |||
| throw std::runtime_error("Index already inited"); | |||
| } | |||
| appr_alg = new hnswlib::HierarchicalNSW<dist_t>(l2space, path_to_index, false, 0, allow_replace_deleted, normalize, is_persistent_index); | |||
| appr_alg->checkIntegrity(); | |||
There was a problem hiding this comment.
Can we add a rust level test that somehow corrupts the index and verifies we get the error?
There was a problem hiding this comment.
I've added a rust unit test that corrupts the index and verifies the error message.
Sicheng-Pan
force-pushed
the
12-30-_enh_validate_hnsw_index_integrity_on_load
branch
from
b01f314 to
232c6d4
Compare
HammadB
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
checkIntegrity()method is added to theload()method in the binding.Test plan
How are these changes tested?
This should not break any existing test cases
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
N/A