Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF]: Fixing double deserialization issue - 30% performance improvement #3310

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Dec 16, 2024

Description of changes

Closes #3309

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Removes body parameters from API routes, adds OpenAPI extras to preserve API docs
    • Update the response classes for exceptions to use ORJSON instead of JSON response objects

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

Copy link
Contributor Author

tazarov commented Dec 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tazarov tazarov changed the title perf: Fixing double deserialization issue - 30% performance improvment [PERF]: Fixing double deserialization issue - 30% performance improvment Dec 16, 2024
@tazarov tazarov changed the title [PERF]: Fixing double deserialization issue - 30% performance improvment [PERF]: Fixing double deserialization issue - 30% performance improvement Dec 16, 2024
@tazarov tazarov added bug Something isn't working Local Chroma An improvement to Local (single node) Chroma labels Dec 16, 2024
@tazarov tazarov requested review from drewkim and itaismith December 16, 2024 09:51
Copy link
Contributor

@drewkim drewkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tazarov tazarov merged commit 8b93564 into main Dec 18, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Local Chroma An improvement to Local (single node) Chroma
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Double deserialization (single node and hosted Chroma version affected)
2 participants