Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Remove log messages in happy hot paths #3300

Merged
merged 4 commits into from
Dec 13, 2024
Merged

[ENH] Remove log messages in happy hot paths #3300

merged 4 commits into from
Dec 13, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Dec 13, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Removes a few msgs that get logged in the happy path every 10 secs

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia sanketkedia changed the title Remove more msgs [ENH] Remove log messages in hot paths Dec 13, 2024
@sanketkedia Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sanketkedia sanketkedia changed the title [ENH] Remove log messages in hot paths [ENH] Remove log messages in happy hot paths Dec 13, 2024
@sanketkedia sanketkedia requested a review from rescrv December 13, 2024 18:22
@sanketkedia sanketkedia marked this pull request as ready for review December 13, 2024 18:22
rescrv
rescrv approved these changes Dec 13, 2024
View reviewed changes
go/pkg/log/repository/log.go Outdated Show resolved Hide resolved
go/pkg/sysdb/metastore/db/dao/collection.go Outdated Show resolved Hide resolved
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Dec 13, 2024 •
edited
Loading

Merge activity

  • Dec 13, 4:17 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 13, 4:17 PM EST: A user merged this pull request with Graphite.

@sanketkedia sanketkedia merged commit 4fe7018 into main Dec 13, 2024
72 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@sanketkedia @github-actions
[ENH] Remove log messages in happy hot paths (#3300)
67081c7 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
   - Removes a few msgs that get logged in the happy path every 10 secs

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust

## Documentation Changes
None
chroma-droid pushed a commit that referenced this pull request Dec 13, 2024
@sanketkedia @github-actions
[ENH] Remove log messages in happy hot paths (#3300)
d69c062 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
   - Removes a few msgs that get logged in the happy path every 10 secs

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust

## Documentation Changes
None
sanketkedia added a commit that referenced this pull request Dec 13, 2024
@chroma-droid @sanketkedia
[HOTFIX] applying PR #3300 to rc/2024-12-13 (#3302)
919cac7 
This PR cherry-picks the commit 4fe7018
onto rc/2024-12-13. If there are unresolved conflicts, please resolve
them manually.

Co-authored-by: Sanket Kedia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rescrv rescrv rescrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @rescrv