Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Deprecate FetchSegmentOperator #3261

Merged
merged 5 commits into from
Dec 17, 2024
Merged

[ENH] Deprecate FetchSegmentOperator #3261

merged 5 commits into from
Dec 17, 2024

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Dec 6, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • N/A
  • New functionality
    • Deprecate FetchSegmentOperator since the query node already receives the full collection information from the frontend.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
N/A

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

This was referenced Dec 6, 2024
Merged
Merged
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Dec 6, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan mentioned this pull request Dec 6, 2024
Merged
1 task
@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review December 6, 2024 19:40
@Sicheng-Pan Sicheng-Pan marked this pull request as draft December 6, 2024 19:50
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 3be574d to e02d7a5 Compare December 6, 2024 21:44
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from e29fd4a to f20b2fb Compare December 6, 2024 21:44
@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review December 6, 2024 22:08
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from e02d7a5 to 7069b15 Compare December 9, 2024 18:56
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from f20b2fb to b6bb831 Compare December 9, 2024 18:56
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 7069b15 to fdc1b25 Compare December 9, 2024 23:26
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from b6bb831 to a25a0eb Compare December 9, 2024 23:26
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from fdc1b25 to 56c2d2d Compare December 9, 2024 23:57
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from a25a0eb to 4ac60f7 Compare December 9, 2024 23:57
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 56c2d2d to a5e387e Compare December 10, 2024 00:46
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from 4ac60f7 to 52afa4a Compare December 10, 2024 00:46
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from a5e387e to 65dfab0 Compare December 10, 2024 01:01
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch 2 times, most recently from 68ee3c2 to 1bd4a7e Compare December 11, 2024 18:30
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 85f280f to 7ce2047 Compare December 11, 2024 18:32
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from 1bd4a7e to 8ac8713 Compare December 11, 2024 18:32
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 7ce2047 to 1022564 Compare December 11, 2024 19:11
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from 8ac8713 to 783f105 Compare December 11, 2024 19:11
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 1022564 to 81e1a4e Compare December 11, 2024 19:32
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from 783f105 to 25503cb Compare December 11, 2024 19:32
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 81e1a4e to 94cb043 Compare December 11, 2024 20:31
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from 25503cb to 76d20fc Compare December 11, 2024 20:31
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 94cb043 to 4003aa8 Compare December 11, 2024 20:44
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from 76d20fc to 931ecb5 Compare December 11, 2024 20:44
@Sicheng-Pan Sicheng-Pan mentioned this pull request Dec 12, 2024
Merged
1 task
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch 3 times, most recently from 41039f0 to d431c5f Compare December 17, 2024 01:51
@Sicheng-Pan Sicheng-Pan mentioned this pull request Dec 17, 2024
Merged
1 task
@Sicheng-Pan Sicheng-Pan force-pushed the 12-05-_enh_propagate_segment_information_from_frontend_to_query_node branch from 69436a2 to b3b4a88 Compare December 17, 2024 02:09
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from d431c5f to beca297 Compare December 17, 2024 02:09
@Sicheng-Pan Sicheng-Pan changed the base branch from 12-05-_enh_propagate_segment_information_from_frontend_to_query_node to graphite-base/3261 December 17, 2024 02:50
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from beca297 to 41b2331 Compare December 17, 2024 02:53
@Sicheng-Pan Sicheng-Pan changed the base branch from graphite-base/3261 to main December 17, 2024 02:53
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from 41b2331 to fd23411 Compare December 17, 2024 02:53
@Sicheng-Pan Sicheng-Pan force-pushed the 12-06-_enh_deprecate_fetchsegmentoperator branch from fd23411 to 1589b5c Compare December 17, 2024 21:55
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Dec 17, 2024 •
edited
Loading

Merge activity

  • Dec 17, 5:51 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 17, 5:51 PM EST: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan merged commit c7c4dda into main Dec 17, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketkedia sanketkedia Awaiting requested review from sanketkedia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sicheng-Pan