Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Introduce spann segment reader #3212

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[ENH] Introduce spann segment reader #3212

merged 3 commits into from
Dec 5, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Nov 29, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Spann segment reader with from_segment impl
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

This was referenced Nov 29, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Nov 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 29, 2024
Merged
Merged
Merged
Merged
@sanketkedia sanketkedia changed the title introduce spann segment reader [ENH] Introduce spann segment reader Nov 29, 2024
@sanketkedia sanketkedia requested a review from HammadB November 29, 2024 06:51
@sanketkedia sanketkedia marked this pull request as ready for review November 29, 2024 06:51
@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

This was referenced Nov 30, 2024
Merged
Merged
Merged
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from aa3f268 to f8bf019 Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 9de114c to 95d8dc1 Compare December 3, 2024 18:35
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from f8bf019 to ad90fbd Compare December 3, 2024 19:06
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 95d8dc1 to 363962b Compare December 3, 2024 19:06
HammadB
HammadB reviewed Dec 3, 2024
View reviewed changes
rust/index/src/spann/types.rs
}

#[allow(clippy::too_many_arguments)]
pub async fn from_id(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split this into two

@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from ad90fbd to b4f91db Compare December 4, 2024 09:56
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 363962b to 0044471 Compare December 4, 2024 09:56
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from b4f91db to 54e68c3 Compare December 4, 2024 17:20
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 0044471 to dba56e1 Compare December 4, 2024 17:20
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from 54e68c3 to 625451d Compare December 4, 2024 17:40
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from dba56e1 to 3c8050c Compare December 4, 2024 17:40
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from 625451d to 87c4dce Compare December 4, 2024 18:10
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 3c8050c to fb3d737 Compare December 4, 2024 18:10
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from 87c4dce to 42d48d8 Compare December 4, 2024 19:16
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from fb3d737 to 2656f3d Compare December 4, 2024 19:17
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from 42d48d8 to ba29605 Compare December 4, 2024 19:26
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 2656f3d to ed569bd Compare December 4, 2024 19:27
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from ba29605 to 78bce69 Compare December 5, 2024 08:54
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from ed569bd to 0172998 Compare December 5, 2024 08:54
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from 78bce69 to e9268e3 Compare December 5, 2024 09:27
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch 2 times, most recently from 9b3271e to 4b14caa Compare December 5, 2024 09:40
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from 151c5d5 to 1c04be4 Compare December 5, 2024 09:44
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 4b14caa to 8336900 Compare December 5, 2024 09:45
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch from 1c04be4 to 8ce3f92 Compare December 5, 2024 10:17
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 8336900 to fa4d982 Compare December 5, 2024 10:18
@sanketkedia sanketkedia force-pushed the 11-25-basic_garbage_collection branch 2 times, most recently from cd79a90 to ab7ce64 Compare December 5, 2024 10:25
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from fa4d982 to 55b5861 Compare December 5, 2024 10:25
@sanketkedia sanketkedia changed the base branch from 11-25-basic_garbage_collection to graphite-base/3212 December 5, 2024 16:06
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 55b5861 to 239186d Compare December 5, 2024 16:07
@sanketkedia sanketkedia changed the base branch from graphite-base/3212 to main December 5, 2024 16:08
@sanketkedia sanketkedia force-pushed the 11-27-introduce_spann_segment_reader branch from 239186d to cebed64 Compare December 5, 2024 16:08
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Dec 5, 2024 •
edited
Loading

Merge activity

  • Dec 5, 3:04 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 5, 3:05 PM EST: A user merged this pull request with Graphite.

@sanketkedia sanketkedia merged commit 65b5e01 into main Dec 5, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @HammadB