[BUG] Remove unnecessary call to get_metadata for query
#3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Sicheng-Pan and the rest of your teammates on |
HammadB
reviewed
Oct 30, 2024
| knns: Sequence[Sequence[VectorQueryResult]] = [[]] * len(plan.knn.embeddings) | ||
| if len(prefiltered_ids) > 0: | ||
| if prefiltered_ids is None or len(prefiltered_ids) > 0: |
There was a problem hiding this comment.
nit - Doesn't this query step always run? Is this only avoiding the case where len(prefiltered_ids) == 0? Can we make that more explicit then?
There was a problem hiding this comment.
Added comments for this
HammadB
approved these changes
Oct 30, 2024
codetheweb
pushed a commit
that referenced
this pull request
Nov 5, 2024
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Restore the logic to skip the filter when the user does not specify any in the `query` - New functionality - ... ## Test plan *How are these changes tested?* - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?* --------- Co-authored-by: Sicheng Pan <[email protected]>
Sicheng-Pan
deleted the
10-30-_bug_remove_unnecessary_call_to_get_metadata_for_query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
queryTest plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?