[ENH] Rendezvous hashing support replication #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
HammadB
commented
Oct 29, 2024
| max_member = member | ||
| score = -hasher(member, key) | ||
| # Invert the score since heapq is a min heap | ||
| heapq.heappush(member_score_heap, (score, member)) |
There was a problem hiding this comment.
this could be made bounded but given small member count its probably fine
codetheweb
approved these changes
Oct 29, 2024
Sicheng-Pan
reviewed
Oct 30, 2024
Sicheng-Pan
reviewed
Oct 30, 2024
1 task
HammadB
added a commit
that referenced
this pull request
Oct 30, 2024
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - One can view the assignment as a binomial distribution. We can take the std dev of the binomial to validate the null hypothesis - that our data is a binomial distribution. - As @Sicheng-Pan pointed out (#2969 (comment)) the previous tolerance to the multi-assign test should have failed. It did not. Sometimes math disagrees with simulation. We were still in two sigma with a tolerance of 75, now the tolerance is 150. - New functionality - None ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?*
codetheweb
pushed a commit
that referenced
this pull request
Nov 5, 2024
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - / - New functionality - Adds support for multiple assignment in HWRH. This works by taking the top-K scores instead of the top 1 ## Test plan *How are these changes tested?* Added a test for uniformity - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
codetheweb
pushed a commit
that referenced
this pull request
Nov 5, 2024
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - One can view the assignment as a binomial distribution. We can take the std dev of the binomial to validate the null hypothesis - that our data is a binomial distribution. - As @Sicheng-Pan pointed out (#2969 (comment)) the previous tolerance to the multi-assign test should have failed. It did not. Sometimes math disagrees with simulation. We were still in two sigma with a tolerance of 75, now the tolerance is 150. - New functionality - None ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
Added a test for uniformity
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
None