Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Delete V1 routes from HTTP API #2968

Conversation

drewkim
Copy link
Contributor

@drewkim drewkim commented Oct 16, 2024

Description of changes

Improvements & Bug fixes

  • Delete wrapper class that houses the old v1 routes for the HTTP routes and switch back to using the correct server instance.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

drewkim commented Oct 16, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @drewkim and the rest of your teammates on Graphite Graphite

@drewkim drewkim marked this pull request as ready for review October 16, 2024 23:13
@drewkim drewkim force-pushed the drew/_enh_delete_v1_routes_from_http_api branch 2 times, most recently from 3807ad5 to 76a9353 Compare October 17, 2024 19:12
@drewkim drewkim force-pushed the drew/_enh_delete_v1_routes_from_http_api branch from 76a9353 to 04417a6 Compare October 18, 2024 00:45
@drewkim drewkim closed this Oct 18, 2024
@drewkim drewkim deleted the drew/_enh_delete_v1_routes_from_http_api branch October 18, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant