-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS client parity and broken out tests #292
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
757c288
try gh actions js tests'
jeffchuber 7af98eb
bump
jeffchuber da33dab
bump
jeffchuber 4193604
bump
jeffchuber 67e552f
bump
jeffchuber 8fb6c02
bump
jeffchuber c1d1cdb
bump
jeffchuber 89e9871
bump
jeffchuber a01f152
bump
jeffchuber 82c2f20
moved to a different PR
jeffchuber eb5475c
new line diff
jeffchuber a46776d
add update embedding and modify collection
jeffchuber 238da80
refactor tests
jeffchuber 6fe13c9
bump to run JS tests (now merged)
jeffchuber 0ccfc54
add additional JS tests
jeffchuber 65fd786
bump version
jeffchuber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,8 +31,8 @@ | |
"test:run": "jest --runInBand", | ||
"test:runfull": "PORT=8001 jest --runInBand", | ||
"test:update": "run-s db:clean db:run && jest --runInBand --updateSnapshot && run-s db:clean", | ||
"db:clean": "cd ../.. && docker-compose -f docker-compose-js-tests.yml down --volumes", | ||
"db:run": "cd ../.. && docker-compose -f docker-compose-js-tests.yml up --detach && sleep 5", | ||
"db:clean": "cd ../.. && docker-compose -f docker-compose.test.yml down --volumes", | ||
"db:run": "cd ../.. && docker-compose -f docker-compose.test.yml up --detach && sleep 5", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we removed an "extra" docker file, but didnt fix this up. |
||
"clean": "rimraf dist", | ||
"build": "run-s clean build:*", | ||
"build:main": "tsc -p tsconfig.json", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added an explicit url for this to make it easy for our OpenAPI spec to pick it up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the python frontend is still using the "old" route...
self.router.add_api_route("/api/v1", self.root, methods=["GET"])
, but we could move it over to the new one as well. perhaps it makes sense to do that in this PR? Though having isolation b/t JS and python changes is nice.