Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add metadata to block #2915

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[ENH] Add metadata to block #2915

merged 2 commits into from
Oct 16, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Oct 9, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Introduces the ability to attach metadata to a block
    • We use the RecordBatch ability to store a custom HashMap of metadata in its schema.
    • The delta.finish() method is used to pass the metadata. So metadata is a one-time writeable piece of data.
    • into_arrow returns the arrow fields, not the actual record batch, so that schema can be attached.
  • New functionality
    • /

Test plan

How are these changes tested?
Tests for this functionality are in a higher PR in the stack

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

github-actions bot commented Oct 9, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Collaborator Author

HammadB commented Oct 9, 2024

@HammadB HammadB force-pushed the hammad/block_metadata branch 2 times, most recently from 3eb8123 to 61bc92f Compare October 11, 2024 05:41
@HammadB HammadB marked this pull request as ready for review October 11, 2024 12:01
@HammadB HammadB requested a review from sanketkedia October 11, 2024 12:32
Copy link
Collaborator Author

HammadB commented Oct 16, 2024

Merge activity

  • Oct 16, 9:29 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 16, 9:30 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 16, 9:31 AM EDT: A user merged this pull request with Graphite.

@HammadB HammadB force-pushed the hammad/block_metadata branch from 1c77d48 to a08b607 Compare October 16, 2024 13:29
@HammadB HammadB merged commit 7951e5d into main Oct 16, 2024
66 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants