configurable cors #251
Merged
configurable cors #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffchuber
commented
Mar 29, 2023
chromadb/config.py
Outdated
| @@ -19,6 +19,7 @@ class Settings(BaseSettings): | |||
| chroma_server_http_port: str = None | |||
| chroma_server_ssl_enabled: bool = False | |||
| chroma_server_grpc_port: str = None | |||
| chroma_server_cors_allow_origins: List[str] = ["http://localhost:3000"] | |||
There was a problem hiding this comment.
maybe the default should be [] now that I think about it
There was a problem hiding this comment.
Yes, running with localhost in CORS by default could cause a security issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
closes #215
Test plan
How are these changes tested?
I'd like feedback on this.
Documentation Changes
None implemented yet