[ENH] max_batch_size -> get_max_batch_size() #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Anush008
pushed a commit
to Anush008/chroma
that referenced
this pull request
Jun 27, 2024
efriis
added a commit
to langchain-ai/langchain
that referenced
this pull request
Nov 5, 2024
There was a change of attribute name which was "max_batch_size". It's now "get_max_batch_size" method. I want to use "create_batches" which is right down below. Please check this PR link. reference: chroma-core/chroma#2305 --------- Signed-off-by: Prithvi Kannan <[email protected]> Co-authored-by: Prithvi Kannan <[email protected]> Co-authored-by: Bagatur <[email protected]> Co-authored-by: Erick Friis <[email protected]> Co-authored-by: Jun Yamog <[email protected]> Co-authored-by: Bagatur <[email protected]> Co-authored-by: ono-hiroki <[email protected]> Co-authored-by: Dobiichi-Origami <[email protected]> Co-authored-by: Chester Curme <[email protected]> Co-authored-by: Duy Huynh <[email protected]> Co-authored-by: Rashmi Pawar <[email protected]> Co-authored-by: sifatj <[email protected]> Co-authored-by: Eric Pinzur <[email protected]> Co-authored-by: Daniel Vu Dao <[email protected]> Co-authored-by: Ofer Mendelevitch <[email protected]> Co-authored-by: Stéphane Philippart <[email protected]>
yanomaly
pushed a commit
to yanomaly/langchain
that referenced
this pull request
Nov 8, 2024
…-ai#27827) There was a change of attribute name which was "max_batch_size". It's now "get_max_batch_size" method. I want to use "create_batches" which is right down below. Please check this PR link. reference: chroma-core/chroma#2305 --------- Signed-off-by: Prithvi Kannan <[email protected]> Co-authored-by: Prithvi Kannan <[email protected]> Co-authored-by: Bagatur <[email protected]> Co-authored-by: Erick Friis <[email protected]> Co-authored-by: Jun Yamog <[email protected]> Co-authored-by: Bagatur <[email protected]> Co-authored-by: ono-hiroki <[email protected]> Co-authored-by: Dobiichi-Origami <[email protected]> Co-authored-by: Chester Curme <[email protected]> Co-authored-by: Duy Huynh <[email protected]> Co-authored-by: Rashmi Pawar <[email protected]> Co-authored-by: sifatj <[email protected]> Co-authored-by: Eric Pinzur <[email protected]> Co-authored-by: Daniel Vu Dao <[email protected]> Co-authored-by: Ofer Mendelevitch <[email protected]> Co-authored-by: Stéphane Philippart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for #2297 as there doesn't seem to be a good way to automatically detect async properties (when converting a set of async class methods to a synchronous version). Having a property that makes a HTTP request is kinda an antipattern regardless.
This is a breaking change. I will prepare a PR for the docs as well.