[ENH]: Retry Strategy for HttpClient #2183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
tazarov
force-pushed
the
trayan-05-11-feat_retry_strategy_for_httpclient
branch
from
d57133a to
809c5d9
Compare
codetheweb
approved these changes
Jun 11, 2024
chromadb/test/test_client.py
Outdated
| retry=RetryStrategy(connect=connect_retries - 1, backoff_factor=1), | ||
| ) | ||
| assert ( | ||
| time.time() - start_time > 4 |
There was a problem hiding this comment.
sorry, not super clear to me, does this work because .heartbeat() is called when initing the client?
chromadb/test/test_client.py
Outdated
|
|
||
|
|
||
| @pytest.fixture | ||
| def retry_session_with_custom_retry(httpserver: HTTPServer) -> chromadb.api.ClientAPI: |
There was a problem hiding this comment.
maybe
Suggested change
| def retry_session_with_custom_retry(httpserver: HTTPServer) -> chromadb.api.ClientAPI: | |
| def retry_session_on_504(httpserver: HTTPServer) -> chromadb.api.ClientAPI: |
tazarov
force-pushed
the
trayan-05-11-feat_retry_strategy_for_httpclient
branch
from
809c5d9 to
0f39d31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Example added
Refs
Future work
The second-order effect of the Retryable strategy is that it is immediately usable/pluggable into the majority of EFs that rely on
requestslibrary