Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GRPC Metadata segment should return results #2073

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Apr 27, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fixes a bug where the segment was returning an empty [] despite constructing the correct result
  • New functionality
    • None

Test plan

How are these changes tested?
We should have a test for this! For now I am getting the bug fix up and we can discuss how to test.

  • [!!!!] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@HammadB HammadB requested a review from beggers April 27, 2024 21:09
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

@beggers beggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha

@HammadB HammadB merged commit f42567e into main Apr 29, 2024
124 checks passed
@HammadB
Copy link
Collaborator Author

HammadB commented Apr 29, 2024

discussed offline: integration tests once enabled should catch this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants