Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In my experience T5 is much better, add comment with that as an option. #206

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

danielgross
Copy link
Contributor

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • ...
  • New functionality
    • ...

Test plan

How are these changes tested?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@HammadB
Copy link
Collaborator

HammadB commented Mar 7, 2023

Hi! Thanks for the suggestion. We want to be rigorous with the suggestions we make to chroma users about which model to use. We mostly chose this model as a lowest common denominator as its more suitable for "lower end" machines.

Maybe instead the comment can link out to the list of options on ST and HF sites?
https://huggingface.co/sentence-transformers
https://www.sbert.net/docs/pretrained_models.html#

In the future, we plan to benchmark them for common use cases and publish our thoughts that way.

@bishwenduk029
Copy link

bishwenduk029 commented Mar 8, 2023

Hi! Thanks for the suggestion. We want to be rigorous with the suggestions we make to chroma users about which model to use. We mostly chose this model as a lowest common denominator as its more suitable for "lower end" machines.

Maybe instead the comment can link out to the list of options on ST and HF sites? https://huggingface.co/sentence-transformers https://www.sbert.net/docs/pretrained_models.html#

In the future, we plan to benchmark them for common use cases and publish our thoughts that way.

I had come across an article few days back, where Nilis from Huggingface has already done some benchmarking independently and not using ChromaDB. But I think this can be useful:

https://medium.com/@nils_reimers/openai-gpt-3-text-embeddings-really-a-new-state-of-the-art-in-dense-text-embeddings-6571fe3ec9d9

@jeffchuber jeffchuber merged commit 2ada82b into chroma-core:main Mar 17, 2023
@danielgross danielgross deleted the patch-2 branch March 18, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants