Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused imports #197

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Conversation

nlsfnr
Copy link
Contributor

@nlsfnr nlsfnr commented Mar 3, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Removed unused imports in various files
    • chromadb/server/__init__.py imported abstractmethod but did not use it - the intended use was obvious and thus added
    • chromadb/server/fastapi/__init__.py imported fastapi.FastAPI but also defined a class FastAPI. The former was aliased to _FastAPI to make the difference explicit and avoid namespace collisions.

@jeffchuber
Copy link
Contributor

@nlsfnr sorry about the excessive delay getting this merged! letting tests pass and then merging in 🎉

@jeffchuber jeffchuber merged commit 725912c into chroma-core:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants