Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Python client sqlite issue #1211

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Oct 6, 2023

Refs: #1206

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Conditional import of sqlite for python client

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python

Additional test in older disto (debian buster) was run:

pip install chromadb-client
root@c26a0fadfcdc:~# python
Python 3.10.12 (main, Jun 13 2023, 12:02:28) [GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sqlite3
>>> print(sqlite3.sqlite_version_info)
(3, 27, 2)
>>> import chromadb
>>>

Documentation Changes

N/A

- Conditional import of sqlite for python client

Refs: chroma-core#1206
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@HammadB
Copy link
Collaborator

HammadB commented Oct 6, 2023

Thanks!

@HammadB HammadB enabled auto-merge (squash) October 6, 2023 14:38
@HammadB HammadB merged commit e357ef3 into chroma-core:main Oct 6, 2023
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants