-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Render.com Terraform Blueprint #1176
[ENH] Render.com Terraform Blueprint #1176
Conversation
- only patch
- Somewhat working version - README is WIP and variables need cleanup
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
- Fixed up readme - Instance creation and deletion working (PR on provider to fix issues + add new functionality) - ISSUE: there seems to be an issue with env vars as they don't seem to be taken into account that needs further investigation. - Variables cleanup
- After updating Render-go upstream and another PR on terraform-render provider, this is finally looking to do almost what we need. There is a Support ticket on Render to clarify why env vars are not populated properly.
- Added a workaround to solved the env var propagation issue.
@beggers ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits and requests to delete some unused variables, but this looks awesome. Chroma everywhere!
- Redid the whole provider env var submission with web service create request and now everything is faster and does not require workarounds.
- Used auth_type var in deployment
Here's a Workaround until provider changes are merged:
cat <<EOF > render-provider/render-patch.patch
Subject: [PATCH] feat: Persistent disk support for Web Service Details
- Added support for EnvVar in ServicePOST request
- Added support for Image type of service in ServicePOST
---
Index: go.mod
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/go.mod b/go.mod
--- a/go.mod (revision 8b0311aadb1546f041b91fdf50275d65f8a6128f)
+++ b/go.mod (date 1695977058413)
@@ -11,6 +11,10 @@
github.com/jackall3n/render-go v1.1.0
)
+replace (
+ github.com/jackall3n/render-go => ../render-go
+)
+
require (
github.com/Masterminds/goutils v1.1.1 // indirect
github.com/Masterminds/semver/v3 v3.1.1 // indirect
EOF
|
This looks great! Always happy to keep state in TF vars |
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
Manual testing
Documentation Changes
README part of the deployment