[ENH]: AWS Terraform Blueprint Improvements #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for restoring from snapshot - Added snapshotting volume before destroy - Bumped default Chroma version to 0.4.12 - Added support for persistent volume mounts (in fstab) - Improved tagging - Made source ranges for the Security Group configurable - Made external Chroma port configurable - Switched to use a GH startup script. Refs: chroma-core#1172
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
beggers
reviewed
Sep 22, 2023
beggers
added a commit
that referenced
this pull request
Sep 22, 2023
## Description of changes `lifecycle` blocks don't allow variables. Right now our example deployment for AWS doesn't work. @tazarov has a fix for this and a few other things in #1173 but I'd like to get the basic fix out before the weekend. ## Test plan local `terraform init` failed before, now works. ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?*
beggers
reviewed
Sep 25, 2023
…ts' into feature/aws-terraform-improvements
beggers
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #1172 and #1135
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
Tests not yet executed.
Documentation Changes
Updated README.md of the blueprint