Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: change chroma client depend Pydantic version #1419

Closed
vmjcv opened this issue Nov 23, 2023 · 3 comments · Fixed by #1421
Closed

[Bug]: change chroma client depend Pydantic version #1419

vmjcv opened this issue Nov 23, 2023 · 3 comments · Fixed by #1421
Labels
bug Something isn't working

Comments

@vmjcv
Copy link

vmjcv commented Nov 23, 2023

What happened?

If it already support Pydantic 2.0 (#893), can you change Chroma_Client depend version
https://github.com/chroma-core/chroma/blob/65f3bb9ae256344d269d847a2d5c41b8ae11075f/clients/python/pyproject.toml#L19C24-L19C24

I believe this change is very simple, you just need to delete "<2.0"

Versions

chroma 0.4.18

Relevant log output

No response
@vmjcv vmjcv added the bug Something isn't working label Nov 23, 2023
@HammadB
Copy link
Collaborator

HammadB commented Nov 23, 2023

Hi @vmjcv thanks for pointing this out. We’ll make the change or are happy to accept it if you do!

@vmjcv
Copy link
Author

vmjcv commented Nov 23, 2023

@HammadB
I am not very familiar with the overall project, so could you please change it
Thanks

@tazarov tazarov mentioned this issue Nov 24, 2023
Merged
1 task
@tazarov
Copy link
Contributor

tazarov commented Nov 24, 2023

@vmjcv, I've created a PR for this. Should be in next release.

HammadB added a commit that referenced this issue Nov 24, 2023
@tazarov @HammadB
[CLN]: Removing pydantic < 2.0 upper bound in python client (#1421)
a0579c4 
Closes #1419 

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Update pyproject.toml to allow python client to use pydantic 2.x

## Test plan
*How are these changes tested?*

- [x] Tests pass locally with `pytest` for python

## Documentation Changes
N/A

Co-authored-by: Hammad Bashir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CLN]: Removing pydantic < 2.0 upper bound in python client amikos-tech/chroma-core
3 participants
@tazarov @HammadB @vmjcv