Skip to content

Commit

Permalink
[CLN] Cleanup query node after pushdown (#3280)
Browse files Browse the repository at this point in the history
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
   - Remove unused impls in query node after query pushdown landed
 - New functionality
   - N/A

## Test plan
*How are these changes tested?*

- [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust

## Documentation Changes
*Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?*
N/A
  • Loading branch information
Sicheng-Pan authored Dec 11, 2024
1 parent a952add commit 5a588a9
Show file tree
Hide file tree
Showing 13 changed files with 4 additions and 2,854 deletions.
2 changes: 2 additions & 0 deletions rust/worker/src/execution/operator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ impl<Output, Error> TaskResult<Output, Error> {
self.result
}

#[allow(dead_code)]
pub(super) fn id(&self) -> Uuid {
self.task_id
}
Expand Down Expand Up @@ -101,6 +102,7 @@ pub(crate) type TaskMessage = Box<dyn TaskWrapper>;
pub(crate) trait TaskWrapper: Send + Debug {
fn get_name(&self) -> &'static str;
async fn run(&self);
#[allow(dead_code)]
fn id(&self) -> Uuid;
fn get_type(&self) -> OperatorType;
}
Expand Down
Loading

0 comments on commit 5a588a9

Please sign in to comment.