Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting DemoFX to Maven project #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

FDelporte
Copy link
Contributor

  • Gradle to be removed?
  • Unclear what to do with getUsedPipeline and getPrismTryOrder as they use com.sun.prism

Tested on Mac with Java 15

1DBA57DD-076B-45A5-A8D8-849614B7E140

@chriswhocodes
Copy link
Owner

Thanks Frank!
I think it's OK to remove gradle for now. Can always add it back later if there's a need. I will remove the prism debug, it's not important.

I want to make the video frame grabber work via reflection so it still operates on JFX8 for the part 3 demo :)

@FDelporte
Copy link
Contributor Author

OK done, Gradle removed

@chriswhocodes
Copy link
Owner

Hi Frank,
I'm going to do a little work on the pom to make a JDK8 profile (assumes JavaFX still part of JDK) and a JDK11+ profile (uses maven central openjfx) and do reflective version of frame grabbing. Should have an updated patch tomorrow :)

@FDelporte
Copy link
Contributor Author

+1 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants