Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove themes #250

Merged
merged 41 commits into from
Sep 20, 2024
Merged

feat: remove themes #250

merged 41 commits into from
Sep 20, 2024

Conversation

chrisvaillancourt
Copy link
Owner

@chrisvaillancourt
refactor: extract logo to separate component
3166a8c
@chrisvaillancourt
refactor: move hover styles into relevant component
3978c7e
@chrisvaillancourt
refactor: extract logo colors to css variables
51b2636
@chrisvaillancourt
build: update dependencies
973b13b
@chrisvaillancourt
fix: remove unnecessary pnpm version specifier
6c1ed29
@chrisvaillancourt
feat: add heading attributes to props
98f47a2
@chrisvaillancourt
wip: header refactor
f7045ad
@chrisvaillancourt
build: update dependencies
a3a13f9
@chrisvaillancourt
feat: simplify header layout
eb9fffb
@chrisvaillancourt
wip: css theme toggle
70f1eb2
@chrisvaillancourt
feat: update header grid
b457a40
@chrisvaillancourt
chore: remove commented out class
3662c3f
@chrisvaillancourt
feat: reuse theme icons
49fc16c
@chrisvaillancourt
feat: improve theme toggle tooltip
d81376d
@chrisvaillancourt
chore: code formatting
56cd14c
@chrisvaillancourt
feat: use updated header
9cd4265
@chrisvaillancourt
feat: add site icon to constants
3819f72
@chrisvaillancourt
fix: remove unused data attribute
64c92aa
@chrisvaillancourt
feat: emit theme change event
182ac87
@chrisvaillancourt
build: update dependencies
9800dc8
@chrisvaillancourt
fix: inline js to prevent theme icon from switching after load
72f3d0a
@chrisvaillancourt
chore: remove unused import
7eed581
@chrisvaillancourt
fix: remove unused class
f870462
@chrisvaillancourt
docs: add info on why we need to inline script
8ded16d
@chrisvaillancourt
chore: remove old theme toggle
d500c03
@chrisvaillancourt
refactor: rename theme toggle
4ab8e97
@chrisvaillancourt
feat: remove theme toggle
83f7c29
@chrisvaillancourt
feat: simplify header layout
12cc491
@chrisvaillancourt
feat: pass logo and nav links as props
098ef4c
@chrisvaillancourt
refactor: pass logo, links, and title as props and slot
2652ad4
@chrisvaillancourt chrisvaillancourt self-assigned this Sep 19, 2024
@chrisvaillancourt
Copy link
Owner Author

chrisvaillancourt commented Sep 19, 2024 •
edited
Loading

TODO:

  • look at what's importing src/lib/theme.ts
  • what colors are allowed in manifest.webmanifest?
  • update icons & favicons to match header and footer

@chrisvaillancourt
Copy link
Owner Author

Created #249 for updating site icons & favicon.

@chrisvaillancourt
Copy link
Owner Author

Although we're only using the dark theme, I'm leaving the light theme in src/lib.theme.ts in case we want to add a theme toggle back in the future.

@chrisvaillancourt
Copy link
Owner Author

resolves #196 (no longer relevant).

@chrisvaillancourt
Copy link
Owner Author

resolves #247

@chrisvaillancourt chrisvaillancourt changed the title draft: feat: remove themes feat: remove themes Sep 20, 2024
@chrisvaillancourt chrisvaillancourt merged commit 96afff3 into main Sep 20, 2024
@chrisvaillancourt chrisvaillancourt deleted the 246/feat/css-only-nav-menu branch September 20, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chrisvaillancourt chrisvaillancourt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add css only hamburger menu
1 participant
@chrisvaillancourt