Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This project has a cyclic dependency to its self in setup.py #19

Closed
ankostis opened this issue Jun 7, 2018 · 11 comments
Closed

This project has a cyclic dependency to its self in setup.py #19

ankostis opened this issue Jun 7, 2018 · 11 comments

Comments

@ankostis
Copy link
Contributor

ankostis commented Jun 7, 2018

For v0.1.31 i get this fro `pipdeptree:

------------------------------------------------------------------------
Warning!! Cyclic dependencies found:
* Naked => Naked => Naked
------------------------------------------------------------------------

And indeed, this project exists in its "install_requires` list.
Is that on purpose?

@chrissimpkins
Copy link
Owner

This project is very experimental and hasn't been developed in some time. Thanks for picking this up. This is not intentional. Happy to take a PR to fix it if you'd like to contribute to it, or I can make the change.

Thanks!

ankostis added a commit to ankostis/naked that referenced this issue Jun 8, 2018
…=[...]) ...

breaking eg `pipdeptree` dues to cycle detected in working-set dependencies.
@ankostis
Copy link
Contributor Author

ankostis commented Jun 8, 2018

Did a PR.
Thanks for being open to this, great ethos 👍

@chrissimpkins
Copy link
Owner

That's how open source projects improve! Thanks for the efforts. Much appreciated. Will merge it this weekend.

@chrissimpkins
Copy link
Owner

btw, if you are using this library and are interested in developing it further, please do feel free to submit other PR. open to new ideas and expansion / revision of source.

chrissimpkins added a commit that referenced this issue Jun 9, 2018
fix(#19): was including myself in setup(install_requires=[...])
@shangxiao
Copy link

Can this please be released? It causes assertion errors when installed with Poetry.

@Satforst
Copy link

Satforst commented Feb 6, 2020 via email

@rrauenza
Copy link

rrauenza commented Aug 3, 2022

Can we get the latest PR pushed as a release?

@LISTERINE
Copy link

@chrissimpkins A new release with this PR would help a lot of people out.

@djkelleher
Copy link

This prevents popular packages (like Cypto) from installing with Poetry. We should probably do that release and not break every package that has this as a dependency.

@chrissimpkins chrissimpkins linked a pull request Nov 6, 2022 that will close this issue
@chrissimpkins chrissimpkins removed a link to a pull request Nov 6, 2022
@chrissimpkins
Copy link
Owner

Done https://pypi.org/project/Naked/

Apologies for the time that it took to address this.

@chrissimpkins
Copy link
Owner

Thanks for the changes to address this Kostis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants