Fix "confirmation" validation by passing model and attribute arguments along to validate
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments along to `validate`
|
Looks good, appreciate the PR! 🎉 |
charlesdemers
deleted the
fix/confirmation-validation-by-passing-model-and-attribute-along
branch
|
Released, should be available in https://github.com/chrismllr/ember-validation-state/releases/tag/1.0.1 |
|
@chrismllr Awesome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
I'm using your addon in my project and fell on an issue: the "confirmation" validation does not work if we don't pass it a
model. I checked the code inember-validatorsand all validators receive amodelandattributeargument (even if they don't use it!) so I forwarded them to fix my issue.I also fixed the types for the
@validationStatedecorator since it didn't pass type check.