Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof LUNAR_AND_SOLAR_EPHEMERIDES_SUBROUTINES (#224) #316

Conversation

dwiyatci
Copy link
Contributor

🕵️ Proof LUNAR_AND_SOLAR_EPHEMERIDES_SUBROUTINES #224

@@ -69,44 +62,43 @@
#
# 1) SPECIFIED GROUND ELAPSED TIME IN CS x B-28 LOADED IN MPAC.
#
# 2) TIMEMO -- TIME AT THE CENTER OF THE RANGE OVER WHICH THE LUNAR
# 2) TIMEMO - TIME AT THE CENTER OF THE RANGE OVER WHICH THE LUNAR
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should we handle sentence/paragraph continuation? Should we leave it be like this or should we put a tab after the number, e.g. 1)⇥ like in https://github.com/chrislgarry/Apollo-11/blob/master/Comanche055/P76.agc? 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I would probably use the format in that file since it is closer to how it looked in the printouts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change those '--' in Proof P76 (#239)

Copy link
Contributor Author

@dwiyatci dwiyatci Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oldmud0 Hmm. If that's the argument, would it be even closer if we just put 3 spaces in the continuation? ⬇️

screen shot 2018-03-12 at 11 33 17 pm

@keller0 🙋‍♂️ I'm actually also kind of undecided about that. Should we use hyphen (-) or double hyphen a.k.a. en dash (--)? Furthermore, in P76, I notice that every full stop (.) is always followed by double spaces -- is it a general rule that we have to follow here?

cc: @chrislgarry @wopian

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwiyatci

  • Single space for new words
  • Double space for new sentences
  • Triple space for indentations

Moving forward, lets change double hyphens to single hyphens to be consistent with the prints. @keller0 its no problem. For new PRs lets do single hyphens unless the printout says otherwise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrislgarry Roger that. 🙇

@wopian wopian added Status: Review Needed Type: Proof Comanche55 and Luminary99 files labels Mar 20, 2018
@wopian wopian added this to the Comanche055 milestone Mar 20, 2018
@wopian wopian merged commit 668e039 into chrislgarry:master Mar 23, 2018
@dwiyatci dwiyatci deleted the proof-lunar-and-solar-ephemerides-subroutines branch March 25, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Proof Comanche55 and Luminary99 files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants