Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/icon colours #43

Merged
merged 7 commits into from
Dec 28, 2017
Merged

Feature/icon colours #43

merged 7 commits into from
Dec 28, 2017

Conversation

chrislennon
Copy link
Owner

@chrislennon chrislennon commented Dec 27, 2017

Closes #34
Based on #42 to compare

Adds a new colour picker to change the colour of the crypto icon.
Currently works on all 'official' icons but doesn't appear to work on the img/temp/TODO.svg (question mark/placeholder icon) and the other icons I created (img/temp/BCG and img/temp/BCC)

@chrislennon
Copy link
Owner Author

Grayscale icons will have an issue - Black/White Icons chosen by the user will be altered based on the background colour for readability - see https://github.com/fifafu/BetterTouchTool/issues/1034

@chrislennon chrislennon merged commit 8dfaa8e into master Dec 28, 2017
@chrislennon chrislennon deleted the feature/icon-colours branch December 28, 2017 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant