Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio "tracking" #47

Closed
chrislennon opened this issue Dec 28, 2017 · 2 comments · Fixed by #52
Closed

Portfolio "tracking" #47

chrislennon opened this issue Dec 28, 2017 · 2 comments · Fixed by #52

Comments

@chrislennon
Copy link
Owner

Add an optional 'point in time' selection to the web-app and create static outputs of price for that specified time.

To investigate:

  • API source for one time or continual (but why?!) checking of the historic price.
  • How to layout the elements:
    • Single element, append datetime. i.e. $1000 - 29/12/2017 00:00
    • Grouped element, show datetime as group name.

suggestion source: reddit

chrislennon added a commit that referenced this issue Dec 30, 2017
Initial PoC for #47
Contains hardcoded values.
@chrislennon
Copy link
Owner Author

f251eb9 makes a start on what is required for historical based pricing.

Still TODO:

  • UI for date/time picking
  • Populating the correct API call with the datetime selected
  • Parsing the response from API for the correct datetime selected
  • Modifying (and forcing?) grouping functionality to show datetime selected

@chrislennon
Copy link
Owner Author

caae9bf implements:

  • UI for picking
  • population of API call and response
  • Forcing grouping

Probably need to think about styling and timezones (urgh -.-)
img_20171230_160821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant