Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Dynamic Build of Coin List #13

Closed
chrislennon opened this issue Dec 16, 2017 · 2 comments · Fixed by #42
Closed

Implement Dynamic Build of Coin List #13

chrislennon opened this issue Dec 16, 2017 · 2 comments · Fixed by #42

Comments

@chrislennon
Copy link
Owner

Coin list may be dynamically generated from API https://www.cryptocompare.com/api/data/coinlist/

This may however bring in interesting considerations with coin icons and will build in a dependancy to external API to the app's load.

@chrislennon chrislennon self-assigned this Dec 16, 2017
@chrislennon
Copy link
Owner Author

1895 coins are returned from the API, with no obvious sorting parameter... some thought required on this 😟

@chrislennon
Copy link
Owner Author

Some further thought on this...

  • UI will need a refactor for this, there is no way displaying ~1900 coins is a sensible way forward
  • Make use of something like selectize to provide a searchable dropdown
  • On selection of the item from dropdown add it to the main window & touchbar and provide colour change functions

Pros:

  • Will provide a lot of futureproofing in the sense of addition of new coins
  • Speed up load times of page as wont need to load large amount of SVGs

Cons:

  • rework/refactor the UI
  • Unsure how to tie the icons/SVGs to the populated list - maybe on the ticker (however wont cover the usage of -ALT icons, for example IOTA-alt)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant