Flow grpc-web service #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is sweet! The trouble in CI is probably that we're no longer emitting the TS files it expects. I've been keeping TS support until I can remove all of the BAZEL stuff that fails when TS file emission is disabled. |
|
@chrisgervang Can't understand what CI wants +MODIFIED_FILES=package-lock.json
+[[ -n package-lock.json ]]
+echo 'ERROR: Changes detected in generated code, please run '\''./generate.sh'\'' and check-in the changes.'
ERROR: Changes detected in generated code, please run './generate.sh' and check-in the changes.
+exit 1Probably package-lock.json is different after some commands? |
chrisgervang
reviewed
Feb 3, 2019
| "resolve": "1.8.1", | ||
| "semver": "5.6.0", | ||
| "source-map": "0.5.7" | ||
| "@babel/code-frame": "^7.0.0", |
There was a problem hiding this comment.
The CI build error is happening since you're using NPM v6 instead of v5 judging by this lock file change. I think I just need to update the CI config to use a new NPM version.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.