[Won't Merge] Proof Of Concept: JSON Types #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cbfc2b2.
|
How this knows what type to serialize and deserialize? |
This reverts commit cbfc2b2.
chrisgervang
changed the title
|
@goodmind I'm just trying something here. Updated the description. |
|
why do we wanna duplicate the scripts here? |
shanshanzhu
reviewed
Feb 26, 2019
| @@ -54,6 +55,12 @@ withAllStdIn((inputBuff: Buffer) => { | |||
| codeGenResponse.addFile(thisFileFlow); | |||
| } | |||
|
|
|||
| // Generate Json Flowtype Files | |||
| const thisFileFlow = new CodeGeneratorResponse.File(); | |||
|
If user uses pbjs, it would be nice if 'google-protobuf' can be removed from the dependency in package.json for the pbjs use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't be merged. This is an experiment to see how easy it would be to add additional build targets (like Protobuf.js compatible types)