-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions for Scala, Akka and Scalatest. #65
base: master
Are you sure you want to change the base?
Conversation
Akka 2.4.1 does not support Scala 2.10. Do you still want to support this Scala version? |
What do you guys think? |
I really like the cleanups but I'm not a fan of the package change, what's the motivation ? |
My package names were somewhat arbitrary (digital-achiever as a "-" so it is a no-go). My primary motivation was to lay things out more conventionally (files in a directory that has the same hierarchy as the package) and with a package name that is OK for Maven. Also, sbt's publishLocal wants the package to match the actual organisation specified in the sbt file. So really not fussy about the actual name :). Let me know what works for you and I will refactor. |
Those package names (and matching directory tree) are Java-isms not required in Scala. Unless this has changed lately in some official way, I'd prefer not to use a fully-qualified package name. I'm not sure about the impact on publishLocal, but I've never had any problem building/publishing Scala libs this way. The rest of the cleanup looks good to me. If you want a quick merge you can separate these issues and we can discuss package naming in another PR. |
I have had some issues with package names not matching organisation in Ivy. |
Are you certain you've correctly identified the source of your problem? If you are correct, libs like Akka also have this problem. I'm assuming they either don't experience it, mitigate it somehow (we could do the same here) or don't deem the limitation worth changing package names for. Is the approach in this library any more offensive? In Akka's case, the organization is "com.typesafe.akka" but the package names are short and sweet (ie. akka.actor). |
Brain fart here.... Do you want the package to be just brando? And are you happy to put it in a separate directory? |
so? |
Hey, do you think you can fix the Travis failure? |
# Conflicts: # project/build.properties # project/plugins.sbt
User Horn SBT Repo
This brings the packages up to current versions.