Support for node 0.11.x #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, also see: #41 |
|
Yeah. Thanks. |
|
I tested this with my application on node v0.10.25 and everything was happy. |
|
Thanks for your work on this. A new version (0.11.0) has just been published. |
|
Thanks a lot! |
|
👍 I get ocd about refactoring! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title mentions, this pull request is my first attempt to support node v0.11.x.
I mainly used nan.h to give me the macros I needed to support node 0.8, 0.10, 0.11 without much effort.
Just for reference, I was able to build this on v0.8.26, v0.10.22, and v0.11.13. Other versions are probably also supported, although nan.h didn't appear to go along with v0.11.12 that well.
I ran npm test (node test/unittest.js) and everything succeeded, but I believe the current test base (test/unittest.js) is kind of thin, and we should have much much more tests.
I have another pending branch at #42 but for convenience purposes I made a different branch for this one and I would be very happy if you could review the source and hopefully pull it in the main repository.