Fix elastic#21355, visualization controls showing up in reports

chrisdavies · Jul 27, 2018 · 76f06cf · 76f06cf
1 parent 7a0c61f
commit 76f06cf
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 20 deletions.
diff --git a/x-pack/plugins/reporting/export_types/printable_pdf/server/lib/layouts/preserve_layout.css b/x-pack/plugins/reporting/export_types/printable_pdf/server/lib/layouts/preserve_layout.css
@@ -42,27 +42,31 @@ discover-app .discover-table-footer {
   display: none;
 }
 
+
+/**
+ * The global banner (e.g. "Help us improve Elastic...") should not print.
+ */
+#globalBannerList {
+  display: none;
+}
+
 /**
  *  Visualize Editor Tweaks
  */
+
 /* hide unusable controls */
-visualize-app
-visualize
-> :not(.vis-editor-content):not(.vis_editor)/* all non-content rows in interface */,
-visualize-app
-visualize
-.vis-editor-content
-.default-vis-editor
-> :not(.vis-editor-canvas):not(.vis_editor) {
-display: none;
+visualize-app visualize > :not(.vis-editor-content):not(.vis_editor), /* all non-content rows in interface */
+visualization-editor .default-vis-editor > :not(.vis-editor-canvas) {
+  display: none;
 }
+
 /** THIS IS FOR TSVB UNTIL REFACTOR **/
 .vis_editor__visualization {
-position: static !important;
+  position: static !important;
 }
 .vis-editor-hide-for-reporting {
-/* all non-content rows in interface */
-display: none;
+  /* all non-content rows in interface */
+  display: none;
 }
 /**  END TSVB BAD BAD HACKS **/
 

diff --git a/x-pack/plugins/reporting/export_types/printable_pdf/server/lib/layouts/print.css b/x-pack/plugins/reporting/export_types/printable_pdf/server/lib/layouts/print.css
@@ -41,18 +41,21 @@ discover-app .discover-table-footer {
   display: none;
 }
 
+/**
+ * The global banner (e.g. "Help us improve Elastic...") should not print.
+ */
+
+#globalBannerList {
+  display: none;
+}
+
 /**
  *  Visualize Editor Tweaks
  */
+
 /* hide unusable controls */
-visualize-app
-  visualize
-  > :not(.vis-editor-content):not(.vis_editor)/* all non-content rows in interface */,
-visualize-app
-  visualize
-  .vis-editor-content
-  .default-vis-editor
-  > :not(.vis-editor-canvas):not(.vis_editor) {
+visualize-app visualize > :not(.vis-editor-content):not(.vis_editor), /* all non-content rows in interface */
+visualization-editor .default-vis-editor > :not(.vis-editor-canvas) {
   display: none;
 }
 /** THIS IS FOR TSVB UNTIL REFACTOR **/